[FFmpeg-devel] [PATCH/RFC] Prefer getaddrinfo over gethostbyname

[Måns Rullgård]

Martin Storsj? <martin at martin.st> writes:

> On Fri, 8 Jan 2010, M?ns Rullg?rd wrote:
>
>> Martin Storsj? <martin at martin.st> writes:
>
>> >> >      type=$2
>> >> > +    type_quoted=$(echo "$type" | sed 's/ /_/g')
>> >> >      shift 2
>> >> >      disable $type
>> >> 
>> >> You missed one.
>> >
>> > Missed one of what?
>> 
>> The disable line.
>
> Ah, good catch.
>
>> >> Use enable_safe/disable_safe instead.  They do the required
>> >> replacements already.
>> >
>> > No, they don't escape spaces at the moment:
>> >
>> >> enable_safe(){
>> >>     enable $(echo "$*" | sed 's/[^A-Za-z0-9_ ]/_/g')
>> >> }
>> >
>> > And if they were made to do that, enabling more than one item at a time 
>> > would break.
>> 
>> Right... that can be fixed though.  Give me a moment.
>
> Ping, any progress on this?

Done.

-- 
M?ns Rullg?rd
mans at mansr.com