[FFmpeg-devel] [PATCH] Clean up ipv6 vs the udp protocol

[Luca Abeni]

Martin Storsj? wrote:
> Hi,
> 
> Here's an updated patch that cleans up the ipv6 configure check and 
> removes the ipv4 code path from the udp protocol.
> 
> Patch 01 was ok'd by Ronald and Luca A.
> 
> Patch 02 is a new try, that renames CONFIG_IPV6 into 
> CONFIG_IPV6_MULTICAST, removes most of the CONFIG_IPV6 checks in udp.c 
> except the ones that explicitly require ipv6 specific structs and defines.

I am obviously missing something, but...
[...]
@@ -182,9 +177,11 @@ static int is_multicast_address(struct sockaddr *addr)
      if (addr->sa_family == AF_INET) {
          return IN_MULTICAST(ntohl(((struct sockaddr_in *)addr)->sin_addr.s_addr));
      }
+#if CONFIG_IPV6_MULTICAST
      if (addr->sa_family == AF_INET6) {
          return IN6_IS_ADDR_MULTICAST(&((struct sockaddr_in6 *)addr)->sin6_addr);
      }
+#endif
[...]
Why is this needed?


				Luca