[FFmpeg-devel] [PATCH] fix stream copy
Maksym Veremeyenko
verem
Thu Jan 14 11:15:13 CET 2010
Michael Niedermayer ???????(??):
[...]
> first you are reindenting code in a functional patch
> second, you remove code at random without any explanation.
> Noone is interrested if a random change fixes your single specific file
> If you want this code removed you must explain why the original reason
> why it was added no longer applies
> Iam of course not in favor of every 6 month fliping a piece of code between
> 2 alternatives as it fixes A and break B then fixes B and breaks A
it remove code parts introduced in two commits:
------------------------------------------------------------------------
r6920 | michael | 2006-11-06 23:54:23 +0200 (Mon, 06 Nov 2006) | 2 lines
2nd try for -vcodec copy timebase selection last one choose 1fps due to
broken opendivx stream in avi (avi had the correct 15
------------------------------------------------------------------------
and
------------------------------------------------------------------------
r6847 | michael | 2006-10-31 02:39:02 +0200 (Tue, 31 Oct 2006) | 3 lines
better timebase selection heuristic for video stream copy
fixes -ss -t -vcodec copy
------------------------------------------------------------------------
that is one fix for /broken opendivx stream/ and second is /heuristic/ -
that why i decide to remove them...
Anyway you are right - that is another workaround.
During stream copy there are no actually information about
codec->time_base because of format context do not set it value and
av_decoder_init not been called in a hope that codec->time_base will be
/Set by libavcodec./
So the only idea to find solution is to check if read and written
packets has proper pts values.
May be you have a idea or some hints for me?
--
________________________________________
Maksym Veremeyenko
More information about the ffmpeg-devel
mailing list