[FFmpeg-devel] [PATCH][RFC] add a list of generic tag names

[Baptiste Coudurier]

Hi,

Again thanks a lot for this work.

On 1/15/10 1:07 AM, Anton Khirnov wrote:
> ping/rebased against HEAD
>
> [...]
 >
> + *
> + * album        -- name of the set this work belongs to
> + * albumartist  -- main author of the set/album, if different from artist.
> + *                 e.g. 'Various Artists' for compilation albums.

album_artist

already used in mov muxer. I'd say make '_' word seperator. Can you 
please write it in this document ?

> + * artist       -- main author of the work

Humm, I'm not sure about the description of artist.
Artist is used for the singer usually, and it's not necessarly the 
"author" in the sense that he didn't write the song. It's not that easy 
though I admit.

> + * comment      -- any additional description of the file
> + * composer     -- who composed the work, if different from artist
> + * copyright    -- name of copyright holder
> + * date         -- date when the work was created, preferably in ISO 8601
> + * disc         -- number of a subset, e.g. disc in a multi-disc collection
> + * encoder      -- name/settings of the software/hardware that produced the file
> + * encodedby    -- person/group who created the file

encoded_by

 > [...]
 >
> @@ -211,7 +211,7 @@ static int parse_tag(AVFormatContext *s, const uint8_t *buf)
>       get_string(s, "title",   buf +  3, 30);
>       get_string(s, "artist",  buf + 33, 30);
>       get_string(s, "album",   buf + 63, 30);
> -    get_string(s, "year",    buf + 93,  4);
> +    get_string(s, "date",    buf + 93,  4);

This looks like "year" to me. 4 digits. like TYER in id3v2
This applies everywhere were the 4 digits are used.
The most common practice is to put only year, like in all my mp3/m4a 
collection.

>       get_string(s, "comment", buf + 97, 30);
>       if (buf[125] == 0&&  buf[126] != 0)
>           av_metadata_set2(&s->metadata, "track", av_d2str(buf[126]), AV_METADATA_DONT_STRDUP_VAL);
> diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
> index 7cf3b22..803e054 100644
> --- a/libavformat/id3v2.c
> +++ b/libavformat/id3v2.c
> @@ -240,20 +240,25 @@ const AVMetadataConv ff_id3v2_metadata_conv[] = {
>       { "TCO",  "genre"},
>       { "TCOP", "copyright"},
>       { "TDRL", "date"},
> -    { "TENC", "encoder"},
> -    { "TEN",  "encoder"},
> +    { "TENC", "encodedby"},
> +    { "TEN",  "encodedby"},

Finally :)
encoded_by also

>       { "TIT2", "title"},
>       { "TT2",  "title"},
>       { "TLAN", "language"},
>       { "TPE1", "artist"},
>       { "TP1",  "artist"},
> +    { "TPE2", "albumartist"},
> +    { "TP2",  "albumartist"},

album_artist.

> +    { "TPE3", "performer"},
> +    { "TP3",  "performer"},
>       { "TPOS", "disc"},
>       { "TPUB", "publisher"},
>       { "TRCK", "track"},
>       { "TRK",  "track"},
> -    { "TSOA", "albumsort"},
> -    { "TSOP", "authorsort"},
> -    { "TSOT", "titlesort"},
> +    { "TSOA", "album-sort"},
> +    { "TSOP", "author-sort"},
> +    { "TSOT", "title-sort"},

'_' for all 3, to be consistent.

[...]

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org