[FFmpeg-devel] [PATCH] fix ffmpeg crash on reading "non-interleved" DV type 1 AVI files

[Michael Niedermayer]

On Fri, Jan 15, 2010 at 11:45:31AM +0200, Maksym Veremeyenko wrote:
> Michael Niedermayer ???????(??):
>> On Thu, Jan 14, 2010 at 06:38:37PM +0200, Maksym Veremeyenko wrote:
> [...]
>>> Am i wrong?
>> the correct solution is to use chained demuxers,
> Could you clarify?

its some work to redesign how avi and dv are connected.


>
> Should it be special case like:
> [...]
>     if(avi->non_interleaved){
> [...]
>         if (CONFIG_DV_DEMUXER && avi->dv_demux) {
> [...]
>
> I may be wrong, but it seems it useless since sync audio packet and video 
> frames stores in the same DV frame for DV type 1 AVI.
>
>> failing that, a single stream cant be non_interleaved whatever sets it
>> is likely wrong
>
> so if setted non_interleaved flag for DV type 1 AVI file is wrong?

iam not sure yet, maybe its wrong, maybe not.

does follwing work for the file?

+    if(!ast || !st->nb_index_entries)
-    if(!st->nb_index_entries)
        continue;

and moving ast uses behind this
this would be an option if it turns out non_interleaved actually is correct,
one could after all create a very oddly broken avi that might need it for
dv.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100115/a26b5c5d/attachment.pgp>