[FFmpeg-devel] [PATCH] Enable proper IPv6 functions on windows

[Reimar Döffinger]

On Sat, Jan 16, 2010 at 11:05:24AM +0100, Reimar D?ffinger wrote:
> On Sat, Jan 16, 2010 at 11:42:56AM +0200, Martin Storsj? wrote:
> > Yes, your approach is much simpler in that sense, and shouldn't have any 
> > thread safety issues either. GetModuleHandle instead of LoadLibrary should 
> > be ok, too, since we actually link to that dll. The only drawback is that 
> > it pollutes the generic fallback wrappers with platform specific code.
> 
> I don't dispute it's ugly, but the configure changes don't exactly look
> non-ugly to me either while giving much worse usability.
> 
> > WinCE itself actually supports IPv6 already, but the mingw32ce headers may 
> > need a little fixing (currently that part is unmodified from the normal 
> > mingw version and only defines getaddrinfo if _WIN32_WINNT >= 0x0501, but 
> > probably should be improved to have a similar check for _WIN32_WCE 
> > instead.)
> 
> I don't know how old those versions are, but it's certainly not like
> all win CE versions support getaddrinfo, according to Microsoft it is
> only starting from these versions:
> Windows Embedded CE	Windows CE .NET 4.1 and later
> Windows Mobile	Windows Mobile Version 5.0 and later

Considering all this, I oppose making hard-linked getaddrinfo the default,
because I am quite sure that the number of people using Win9x, Win2k or
Windows Mobile before 5 >>> number of people who care about IPv6 on Windows.
Of you do not want to use the solution I proposed, have them explicitly
enable getaddrinfo on Windows.