[FFmpeg-devel] [PATCH 2/3] Indeo 5 decoder: common DSP functions

[Reimar Döffinger]

On Sun, Jan 17, 2010 at 09:55:45PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > On Sun, Jan 17, 2010 at 10:18:46PM +0100, Michael Niedermayer wrote:
> >> On Sun, Jan 17, 2010 at 09:31:43PM +0100, Reimar D?ffinger wrote:
> >> > However reviews be me as usual will be more in the details since I usually
> >> > can't be bothered to really try to understand the overall code.
> >> 
> >> Maybe reading the spec, we do have a "spec" dont we could help understanding
> >> the overall code.
> >
> > Sure, it's more that it's a different style of review I still have to learn/
> > get used to and I also don't have so much free time anymore, so I probably
> > won't (particularly not while I think I find enough things even like this).
> > It's easier to just see if you maybe have more time once I'm done :-)
> 
> The problems is that micro-optimising at an early stage is often a
> waste of time...

If you haven't noticed unless I have a certain goal and it is a really
popular codec I just don't really care about speed.
I only point out the really blatant things, and I think that's not a waste
of time since it should mean the original author learns something worth
learning because it can be applied often.
Unless you mean "micro-optimizing for readability", in which case I simply
hope it will still help with the big optimizations if necessary :-)