[FFmpeg-devel] [PATCH] Improved warning message in libswscale/yuv2rgb.c

[Michael Niedermayer]

On Tue, Jan 19, 2010 at 10:28:17AM +0800, Zuxy Meng wrote:
> Hi,
> 
> 2010/1/18 Ramiro Polla <ramiro.polla at gmail.com>:
> > On Mon, Jan 18, 2010 at 1:03 AM, Zuxy Meng <zuxy.meng at gmail.com> wrote:
> >> 2010/1/16 Michael Niedermayer <michaelni at gmx.at>:
> >>> On Fri, Jan 15, 2010 at 04:58:48PM +0800, Zuxy Meng wrote:
> >>>> The "No accelerated colorspace conversion found." message gives us
> >>>> little information on what is lacked. This patch appends source and
> >>>> destination to the message.
> >>>>
> >>>> --
> >>>> Zuxy
> >>>> Beauty is truth,
> >>>> While truth is beauty.
> >>>> PGP KeyID: E8555ED6
> >>>
> >>>> ?yuv2rgb.c | ? ?2 +-
> >>>> ?1 file changed, 1 insertion(+), 1 deletion(-)
> >>>> 364a4264d808f9a7ccf347b1d36694d3fc179ca5 ?warning.diff
> >>>> Index: libswscale/yuv2rgb.c
> >>>> ===================================================================
> >>>> --- libswscale/yuv2rgb.c ? ? ?(?? 30306)
> >>>> +++ libswscale/yuv2rgb.c ? ? ?(??????)
> >>>> @@ -525,7 +530,7 @@
> >>>> ? ? ?if (t)
> >>>> ? ? ? ? ?return t;
> >>>>
> >>>> - ? ?av_log(c, AV_LOG_WARNING, "No accelerated colorspace conversion found.\n");
> >>>> + ? ?av_log(c, AV_LOG_WARNING, "No accelerated colorspace conversion found from %i to %i.\n", c->srcFormat, c->dstFormat);
> >>>
> >>> human readable strings would be better than indexes into an enum
> >>
> >> Sure but adding a table for this message only looks like an overkill for me...
> >
> > use sws_format_name()
> 
> Thanks! So I guess the attached is OK then.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100119/95d76cda/attachment.pgp>