[FFmpeg-devel] [PATCH] Expand sws_setColorspaceDetails doxygen

[Michael Niedermayer]

On Wed, Jan 20, 2010 at 06:26:15AM -0500, David Conrad wrote:
> Hi,
> 
> I guess table was supposed to be the coefficients for RGB->YUV conversion, but it's not used for anything.
> 

> commit 8fc2063d5cc81b2c867d7179a9f2fc005311f8eb
> Author: David Conrad <lessen42 at gmail.com>
> Date:   Wed Jan 20 05:17:35 2010 -0500
> 
>     Expand sws_setColorspaceDetails doxygen
> 
> diff --git a/swscale.h b/swscale.h
> index 9e14262..27f4d0a 100644
> --- a/swscale.h
> +++ b/swscale.h
> @@ -196,8 +196,13 @@ int sws_scale_ordered(struct SwsContext *context, const uint8_t* const src[],
>  #endif
>  
>  /**
> - * @param inv_table the yuv2rgb coefficients, normally ff_yuv2rgb_coeffs[x]
> - * @param fullRange if 1 then the luma range is 0..255 if 0 it is 16..235
> + * @param inv_table  the yuv2rgb coefficients, normally ff_yuv2rgb_coeffs[x]
> + * @param srcRange   1 if the luma range is 0..255, 0 if it is 16..235

whatever you prefer


> + * @param table      unused

no, thats not the intended API


> + * @param dstRange   1 if the luma range is 0..255, 0 if it is 16..235
> + * @param brightness fixed point, with 0 meaning no change
> + * @param contrast   fixed point, with 1<<16 meaning no change
> + * @param saturation fixed point, with 1<<16 meaning no change
>   * @return -1 if not supported
ok


>   */
>  int sws_setColorspaceDetails(struct SwsContext *c, const int inv_table[4],

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100120/d3f525b5/attachment.pgp>