[FFmpeg-devel] [PATCH] WMA Voice decoder

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Thu, Jan 21, 2010 at 02:06:10PM +0100, Michael Niedermayer wrote:
>> On Thu, Jan 21, 2010 at 12:16:40PM +0000, M?ns Rullg?rd wrote:
>> > Michael Niedermayer <michaelni at gmx.at> writes:
>> > 
>> > > On Thu, Jan 21, 2010 at 11:43:00AM +0000, M?ns Rullg?rd wrote:
>> > >> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> > >> 
>> > >> > On date Wednesday 2010-01-20 16:56:25 -0500, Ronald S. Bultje encoded:
>> > >> > [...]
>> > >> >> +/**
>> > >> >> + * Initialize decoder.
>> > >> >> + */
>> > >> > [...]
>> > >> >
>> > >> > Just a note on the doxy, please use third person,
>> > >> 
>> > >> Please don't.  It looks weird to me, and I've never seen any other
>> > >
>> > > so does you pink bike look to me ;)
>> > >
>> > >> documentation do it.  It's time we stopped this madness.
>> > >
>> > > java*
>> > 
>> > FFmpeg is not written in java.
>> 
>> thats a straw man argument :)
>> 
>> "I've never seen any other documentation do it"
>> "java"
>> "FFmpeg is not written in java"
>> 
>> we could continue this along the lines of
>> "But ffmpeg is written C"
>> "C is a progamming language"
>> ...
>> 
>> this misses the original point though that you tried to argue 3rd person
>> was uncommon and you had not seen it, i do think its quite common and
>> actually standard in some areas like javadocs which syntax we use as well

I haven't read any javadoc since they introduced that rule,
apparently.

> That said, i do think the worst is to waste time to change easy
> understandable comments to a different grammer style and i think we
> dont really disagree on this?

There we agree.

-- 
M?ns Rullg?rd
mans at mansr.com