[FFmpeg-devel] [PATCH]Swap U&V for Metasoft MJPEG codec

[Michael Niedermayer]

On Fri, Jan 22, 2010 at 12:02:48PM +0100, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch fixes issue 1611.
>
> Please comment, Carl Eugen

>  mjpegdec.c |    2 ++
>  1 file changed, 2 insertions(+)
> bd9ad0f927d349b8db30ac535a20cb528f993b2e  patchissue1611.diff

your patch looks like it does swap data1/2 from get_buffer() so what the
decoder outputs does not match what it got from get_buffer(), this seems
problematic
adjusting comp_index where it is initialized seems better if this is
possible

[..]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100125/21a3d1b9/attachment.pgp>