[FFmpeg-devel] [PATCH] broaden ff_set_fixed_vector

[Vitor Sessak]

Ronald S. Bultje wrote:
> Hi,
> 
> $subj. Useful for single-pulse excitation bits in WMAVoice.

> Index: libavcodec/acelp_vectors.h
> ===================================================================
> --- libavcodec/acelp_vectors.h	(revision 21350)
> +++ libavcodec/acelp_vectors.h	(working copy)
> @@ -28,8 +28,11 @@
>  /** Sparse representation for the algebraic codebook (fixed) vector */
>  typedef struct {
>      int      n;
> -    int      x[10];
> -    float    y[10];
> +    struct {
> +        unsigned int single:1;
> +        unsigned int x:31;
> +        float        y;
> +    } pulses[10];
>      int      pitch_lag;
>      float    pitch_fac;
>  } AMRFixed;

I think "single" is a bad name. I'd prefer "has_pitch" (meaning !single).

Besides that, patch ok for the files I maintain (and the others too if 
Michael do not want to comment).

-Vitor