[FFmpeg-devel] [PATCH] h264.c : fix svq3_* function declarations

[Rafaël Carré]

Hi,

svq3_luma_dc_dequant_idct_c and svq3_add_idct_c are defined (extern) in
svq3.c since r21157, but still static in h264.c

Note: I found this issue because of:
/usr/bin/ld: ..../lib/libavcodec.a(h264.o): relocation R_X86_64_PC32
against symbol `svq3_add_idct_c' can not be used when making a shared
object; recompile with -fPIC

When building a shared object against a static libavcodec

With the patch, a correct relocation is generated.


Btw, why not moving the functions to h264.c if it's only used there:
Is the file too big already, or should the functions be used one day in
the svq3 decoder ?

-- 
Rafa?l Carr?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: svq3_h264.diff
Type: text/x-patch
Size: 692 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100127/72898103/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100127/72898103/attachment.pgp>