[FFmpeg-devel] [PATCH] HE-AAC v1 decoder

[Michael Niedermayer]

On Wed, Jan 27, 2010 at 05:53:24AM -0500, Alexander Strange wrote:
> 
> On Jan 26, 2010, at 10:10 PM, Alex Converse wrote:
[...]
> > +    for (k = 0; k < num_bands-1; k++) {
> > +        prod *= base;
> > +        present  = lroundf(start * prod);
> > +        bands[k] = present - previous;
> > +        previous = present;
> > +    }
> 
> You use lroundf() a lot, which is a library call for me. Can't you set the rounding direction (or just ignore it) and cast instead?

whats wrong with lrintf() ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100127/0066dbeb/attachment.pgp>