[FFmpeg-devel] [PATCH] h264.c : fix svq3_* function declarations

[Michael Niedermayer]

On Wed, Jan 27, 2010 at 03:21:59PM +0100, Rafa?l Carr? wrote:
> On Wed, 27 Jan 2010 12:33:03 +0000
> M?ns Rullg?rd <mans at mansr.com> wrote:
> 
> > Rafa?l Carr? <rafael.carre at gmail.com> writes:
> 
> > > diff --git a/libavcodec/h264.c b/libavcodec/h264.c
> > > index e4a47cf..6440b0b 100644
> > > --- a/libavcodec/h264.c
> > > +++ b/libavcodec/h264.c
> > > @@ -43,8 +43,9 @@
> > >  //#undef NDEBUG
> > >  #include <assert.h>
> > >  
> > > -static void svq3_luma_dc_dequant_idct_c(DCTELEM *block, int qp);
> > > -static void svq3_add_idct_c(uint8_t *dst, DCTELEM *block, int
> > > stride, int qp, int dc); +/* from svq3.c */
> > > +void svq3_luma_dc_dequant_idct_c(DCTELEM *block, int qp);
> > > +void svq3_add_idct_c(uint8_t *dst, DCTELEM *block, int stride, int
> > > qp, int dc);
> > 
> > Prototypes for extern functions should be in some header file included
> > both by file(s) containing the definitions and those using the
> > functions.
> 
> Add prototypes to h264.h (without a comment though)
> 
> Prefixed functions with ff_
> 
> -- 
> Rafa?l Carr?

>  h264.c |   11 ++++-------
>  h264.h |    3 +++
>  svq3.c |    4 ++--
>  3 files changed, 9 insertions(+), 9 deletions(-)
> 6f4105e0bcc486db097cf92e87fd08fd94559ce5  svq3-h264.diff

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100127/43f661ba/attachment.pgp>