[FFmpeg-devel] [PATCH] RTP depacketizer for H.263

[Martin Storsjö]

On Tue, 26 Jan 2010, Martin Storsj? wrote:

> On Tue, 26 Jan 2010, Martin Storsj? wrote:
> 
> > On Tue, 26 Jan 2010, Ronald S. Bultje wrote:
> > 
> > > I actually meant to index them all, now you read the memory twice. I.e.:
> > > 
> > > +    flags          =  AV_RB16(buf);
> > > +    startcode      = (flags & 0x0400) >> 17;
> > > +    vrc            =  flags & 0x02;
> > > +    picture_header = (flags & 0x01f8) >> 3;
> > > 
> > > But that's nitpicking, either way is fine with me. If you prefer
> > > current behaviour, then this is OK also. Patch OK.
> > 
> > Updated patch attached, that does things this way. (Named the variable 
> > "header" instead of "flags", since there's already a parameter named 
> > flags.)

Any more opinions on this, or is it ok to be applied?

// Martin