[FFmpeg-devel] [PATCH] allow non-repeating pulse vectors in ff_set_fixed_vector()

[Vitor Sessak]

Vitor Sessak wrote:
> Ronald S. Bultje wrote:
>> Hi Vitor,
>>
>> On Jan 28, 2010, at 7:23 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>>> On Thu, Jan 28, 2010 at 7:12 PM, Ronald S. Bultje 
>>> <rsbultje at gmail.com> wrote:
>>>>
>>>> On Jan 28, 2010, at 6:53 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>>>>> On Thu, Jan 28, 2010 at 9:39 AM, Ronald S. Bultje <rsbultje at gmail.com>
>>>>> wrote:
>>>>>> $subj, used in WMAVoice and adapted from a previous patch by Mans'
>>>>>> suggestions on how to make optimal code with gcc. The nice thing is
>>>>>> that the default behaviour (repeat) can be done in a one-liner for 
>>>>>> all
>>>>>> items in the array, whereas complex behaviour (like WMAVoice,
>>>>>> no-repeat) can be done in ways that punishes that decoder alone, not
>>>>>> others. (hence the "no-repeat" instead of "repeat").
>>>>>
>>>>> Missing changes in siprdec.c (passing AMRFixed.no_repeat_mask
>>>>> uninitialized is a bad idea).
>>>>> Besides that, ok if tested not to break SIPR.
>>>>
>>>> But it doesn't actually use it, do you still want me to set it?
>>>
>>> sipr16k.c uses ff_set_fixed_vector(). Unless I'm missing something,
>>> AMRFixed.no_repeat_mask = 0 behaves as the current code and
>>> AMRFixed.no_repeat_mask = 0xfffff does something different. Since
>>> sipr16k alloc AMRFixed on the stack,  AMRFixed.no_repeat_mask is
>>> initialized to random junk.
>>
>> ff_parse_10pulses_35bits() is changed in the patch already, see the 
>> acelp_vectors.c changes.
> 
> Yes, but what about ff_sipr_decode_frame_16k()?

10l, patch ok.

-Vitor