[FFmpeg-devel] [PATCH] DV muxer: reduce audio fifo size to AVCODEC_MAX_AUDIO_FRAME_SIZE

[Måns Rullgård]

M?ns Rullg?rd <mans at mansr.com> writes:

> Baptiste Coudurier <baptiste.coudurier at gmail.com> writes:
>
>> Hi,
>>
>> On 09/10/2009 01:12 PM, Janne Grunau wrote:
>>> Hi,
>>>
>>> after changing the fifo avaible space check to av_fifo_space, it's
>>> possible to realloc the audio fifos in the DV muxer. The default size is
>>> 100 * AVCODEC_MAX_AUDIO_FRAME_SIZE, currently 19 megabyte per stream.
>>> The short sample muxed during lavftest doesn't need to realloc the fifo
>>> from the new default size of AVCODEC_MAX_AUDIO_FRAME_SIZE. The largest
>>> realloc I've seen during testing was to 6M. Reducing the memory
>>> consumption of the DV muxer by a factor of 2 (meassured with massif).
>>
>> The correct way to mux audio in dv is to use audio interleave code
>> mechanism in audiointerleave.c
>
> So is anyone planning on fixing this?  Is the dv maintainer drunk
> again?

If nobody shows any inclination to fix this "properly" soon, I'll
apply this patch as is.  That ridiculous allocation is becoming
bothersome on small systems.

-- 
M?ns Rullg?rd
mans at mansr.com