[FFmpeg-devel] AMR frame size tables (Was: [PATCH] RTP depacketizer for AMR)

[Michael Niedermayer]

On Fri, Jan 29, 2010 at 07:23:47PM -0500, Vitor Sessak wrote:
> Martin Storsj? wrote:
>> On Wed, 27 Jan 2010, Ronald S. Bultje wrote:
>>> On Wed, Jan 27, 2010 at 7:50 AM, Martin Storsj? <martin at martin.st> 
>>> wrote:
>>>
>>>> +static const uint8_t frame_sizes_nb[16] = {
>>>> +    12, 13, 15, 17, 19, 20, 26, 31, 5, 0, 0, 0, 0, 0, 0, 0
>>>> +};
>>> Can this be shared with the AMR decoder that is in Vitor's patch? (I
>>> didn't see it on quick look.)
>> If we were to share these tables, can they be shared across libavcodec and 
>> libavformat, or should each library contain their own copy of the tables?
>> As said, currently this kind of table is in libavformat/amr.c and in 
>> libavcodec/libopencore-amr.c. If adding an AMR parser to libavcodec, that 
>> would probably need access to the table, too, and the RTP depacketizer in 
>> libavformat needs it likewise.
>
> Indeed such a table is used in AMR. Both with or without the TOC should be 
> ok.
>
> About how to better share this tables across lavc/lavf, I leave this for 
> Diego, Mans and Michael.

things shared between lavf & lavc can be put in lavc but keep in mind this
is then part of its ABI and all theissues with major ver bumping apply

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100130/5c71a4e3/attachment.pgp>