[FFmpeg-devel] [PATCH] Implement av_get_pix_fmt_by_name()

[Stefano Sabatini]

On date Saturday 2010-01-30 13:25:09 +0100, Michael Niedermayer encoded:
> On Sat, Jan 30, 2010 at 11:35:47AM +0100, Stefano Sabatini wrote:
> > On date Friday 2010-01-29 01:19:36 +0100, Michael Niedermayer encoded:
> > > On Fri, Jan 29, 2010 at 12:05:05AM +0100, Stefano Sabatini wrote:
> > [...]
> > > > e5e9c160bfb1e22ea556ae29a1b550288d09b184  implement-get-pix-fmt-by-name.patch
> > > 
> > > if it makes you happy, ok
> > 
> > Just another question, does someone have arguments for preferring
> > 
> > av_get_pix_fmt()           rather than 
> > av_get_pix_fmt_by_name()   ?
> 
> av_name2pix_fmt()
> if the len bothers you

Ugh, that's ugly...

./libpostproc/postprocess.h:90:pp_mode *pp_get_mode_by_name_and_quality(const char *name, int quality);
./libavfilter/avfilter.h:611:AVFilter *avfilter_get_by_name(const char *name);
./libavcodec/avcodec.h:3162:AVCodec *avcodec_find_encoder_by_name(const char *name);
./libavcodec/avcodec.h:3178:AVCodec *avcodec_find_decoder_by_name(const char *name);

but also:
av_find_input_format()

so maybe another solution:
av_find_pix_fmt_by_name()

or:
av_find_pix_fmt()

since there is currently no way to find/get a pixel format but by
name.

But then I have no strong preference amongst these ones:

av_find_pix_fmt_by_name()
av_find_pix_fmt()
av_get_pix_fmt()
av_get_pix_fmt_by_name()

for this reason I wanted to hear if others have preferences+arguments,
otherwise I think I'll go for the shortest variant (av_get_pix_fmt).

Regards.
-- 
FFmpeg = Furious Fast Mournful Programmable Egregious Geek