[FFmpeg-devel] [PATCH] RTSP muxer, round 3

[Ronald S. Bultje]

Hi,

On Fri, Jan 22, 2010 at 3:17 AM, Martin Storsj? <martin at martin.st> wrote:
> On Wed, 20 Jan 2010, Ronald S. Bultje wrote:
>> (Will look at the rest in a bit.)
>
> Here's an updated series, to work with the latest SVN. 0001 is updated to
> fit with the updated parameter signature to rtsp_send_cmd_async, and 0010
> is updated to use the _async version for sending the commands in
> rtsp_write_close (as you did for rtsp_read_close), the rest is unmodified.

General comments:
- should we split this in 3 files (rtsp, rtspdec, rtspenc.c) for
easier maintenance?
- the priv_data is not the same for demuxer and muxer, should we
document that? Did you double check all possible cases that this is
handled OK?
- Luca, did you look also?

I don't have many more specific comments, not sure if this is the best
way but I could be OK with these patches.

Ronald