[FFmpeg-devel] [PATCH 19/28] changed: check some?more?url_fseeks in asf demuxer to avoid problems if file?systemis?unseekable

[Michael Niedermayer]

On Thu, Jul 01, 2010 at 12:21:33PM +0000, Joakim Plate wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > +    if(url_fseek(s->pb, asf->data_object_offset + asf->data_object_size, 
> SEEK_SET) < 0) {
> > > +      asf->index_read= -1;
> > > +      return;
> > > +    }
> > 
> > setting index_read looks broken
> > 
> > [...]
> > 
> 
> The change to index_read is in the wrong patch. It belongs in the the asf hacks 
> patch. The point is to indicate that we have attempted to read index and failed, 
> so we don't try it again.

skiping reading the index if we previously tried and failed makes sense
but this variable is used with != 0 checks that have the semantic of
"did we read the index" IIRC

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100701/46eb5cb4/attachment.pgp>