[FFmpeg-devel] [PATCH 5/6] vorbisdec: remove variable-length arrays

Måns Rullgård mans
Fri Jul 2 01:37:05 CEST 2010


David Conrad <lessen42 at gmail.com> writes:

>> -    uint_fast8_t no_residue[vc->audio_channels];
>> -    uint_fast8_t do_not_decode[vc->audio_channels];
>> +    uint_fast8_t *no_residue = vc->no_residue;
>> +    uint_fast8_t *do_not_decode = vc->do_not_decode;
>>     vorbis_mapping *mapping;
>>     float *ch_res_ptr=vc->channel_residues;
>>     float *ch_floor_ptr=vc->channel_floors;
>> -    uint_fast8_t res_chan[vc->audio_channels];
>> +    uint_fast8_t *res_chan = vc->res_chan;
>
> These 3 can be a constant 255 like channel_ptrs.

I wonder what I was thinking...

> Other than that, okay

Applied with that change.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list