[FFmpeg-devel] [PATCH]Only set attribute_align_arg for x86_32

[Eli Friedman]

2010/7/2 M?ns Rullg?rd <mans at mansr.com>:
> Carl Eugen Hoyos <cehoyos at ag.or.at> writes:
>
>> Hi!
>>
>> AFAIUI, attribute force_align_arg_pointer only exists on x86.-32.
>> Patch fixes warnings on all other architectures when using recent gcc.
>>
>> Please comment, Carl Eugen
>>
>> Index: libavutil/internal.h
>> ===================================================================
>> --- libavutil/internal.h ? ? ?(revision 24002)
>> +++ libavutil/internal.h ? ? ?(working copy)
>> @@ -39,7 +39,7 @@
>> ?#include "timer.h"
>>
>> ?#ifndef attribute_align_arg
>> -#if (!defined(__ICC) || __ICC > 1110) && AV_GCC_VERSION_AT_LEAST(4,2)
>> +#if ARCH_X86_32 && (!defined(__ICC) || __ICC > 1110) && AV_GCC_VERSION_AT_LEAST(4,2)
>> ?# ? ?define attribute_align_arg __attribute__((force_align_arg_pointer))
>> ?#else
>> ?# ? ?define attribute_align_arg
>
> The warning is annoying, but it serves a purpose.

Is the implication here that using attribute_align_arg in code which
isn't specific to x86-32 is wrong?  I don't think that really matches
the way it is used...

-Eli