[FFmpeg-devel] [PATCH] Fix warnings in bidir_refine (in libavcodec/motion_est.c)

[Michael Niedermayer]

On Sat, Jul 03, 2010 at 01:17:56AM -0700, Eli Friedman wrote:
> On Sat, Jul 3, 2010 at 12:45 AM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> >
> > On Sat, Jul 03, 2010 at 12:19:12AM -0700, Eli Friedman wrote:
> > > Patch attached. ?Fixes a bunch of warnings of the form "large integer
> > > implicitly truncated to unsigned type" coming from the static table
> > > "hash". ?No significant change in the generated code.
> >
> > I don't believe that, it generated quite a few useless extra instructions
> > for me (gcc 4.4.4 on x86_64).
> 
> I'm using gcc 4.4.3, so I'll assume I got the same output; the output
> patched was only 1 instruction longer.  Is my threshold for "no
> significant change" not sensitive enough?

no, the threshold is 0 for gcc warning spam workarounds
besides which command line option disables this warning?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100703/0c770b8d/attachment.pgp>