[FFmpeg-devel] [PATCH] Enhance pad filter command-line description.

Stefano Sabatini stefano.sabatini-lala
Sat Jul 3 21:43:01 CEST 2010


On date Friday 2010-07-02 14:11:37 -0600, John Calcote encoded:
> On 7/1/2010 4:33 PM, Stefano Sabatini wrote:
> > On date Friday 2010-07-02 00:08:30 +0200, Michael Niedermayer encoded:
> >   
> >> On Thu, Jul 01, 2010 at 03:50:29PM -0600, John Calcote wrote:
> >>     
> >>> Index: vf_pad.c
> >>> ===================================================================
> >>> --- vf_pad.c    (revision 23945)
> >>> +++ vf_pad.c    (working copy)
> >>> @@ -306,7 +306,7 @@
> >>>
> >>>  AVFilter avfilter_vf_pad = {
> >>>      .name          = "pad",
> >>> -    .description   = NULL_IF_CONFIG_SMALL("Add paddings to the input image."),
> >>> +    .description   = NULL_IF_CONFIG_SMALL("Pad input image to width:height:x:y[:color] (def color: black)."),
> >>>       
> >> interresting, iam not against this
> >>     
> > I'll apply a variant of this tomorrow:
> > "Pad input image to width:height[:x:y[:color]] (default x and y: 0, default color: black)."
> >   
> 
> Hi Stefano.
> 
> Thanks - your version is even better.

Committed, thanks for the contribution.

> I've also submitted a patch to documentation to add "deprecation"
> comments to the -cropleft/right/bottom/top options and "non-functional"
> comments to the -padleft/right/top/bottom options. The patch also
> removes the -padleft/right/top/bottom options from the option list in
> ffmpeg (since using them fails the command anyway).

Looks fine, regards.
-- 
FFmpeg = Friendly Fancy Meaningless Problematic Easy Geisha



More information about the ffmpeg-devel mailing list