[FFmpeg-devel] [PATCH] Removed -padtop,right,bottom,left,color options; added comments to ffmpeg doc

[John Calcote]

On 7/4/2010 4:53 AM, Stefano Sabatini wrote:
> On date Saturday 2010-07-03 19:13:24 -0600, John Calcote encoded:
> [...]
>   
>> Index: ffmpeg.c
>> ===================================================================
>> --- ffmpeg.c    (revision 24008)
>> +++ ffmpeg.c    (working copy)
>> @@ -4226,11 +4226,6 @@
>> 	 { "cropbottom", HAS_ARG | OPT_VIDEO, {(void*)opt_frame_crop_bottom}, "Deprecated, please use the crop avfilter", "size" },
>> 	 { "cropleft", HAS_ARG | OPT_VIDEO, {(void*)opt_frame_crop_left}, "Deprecated, please use the crop avfilter", "size" },
>> 	 { "cropright", HAS_ARG | OPT_VIDEO, {(void*)opt_frame_crop_right}, "Deprecated, please use the crop avfilter", "size" },
>> -    { "padtop", HAS_ARG | OPT_VIDEO, {(void*)opt_pad}, "set top pad band size (in pixels)", "size" },
>> -    { "padbottom", HAS_ARG | OPT_VIDEO, {(void*)opt_pad}, "set bottom pad band size (in pixels)", "size" },
>> -    { "padleft", HAS_ARG | OPT_VIDEO, {(void*)opt_pad}, "set left pad band size (in pixels)", "size" },
>> -    { "padright", HAS_ARG | OPT_VIDEO, {(void*)opt_pad}, "set right pad band size (in pixels)", "size" },
>> -    { "padcolor", HAS_ARG | OPT_VIDEO, {(void*)opt_pad}, "set color of pad bands (Hex 000000 thru FFFFFF)", "color" },
>> 	 { "intra", OPT_BOOL | OPT_EXPERT | OPT_VIDEO, {(void*)&intra_only}, "use only intra frames"},
>> 	 { "vn", OPT_BOOL | OPT_VIDEO, {(void*)&video_disable}, "disable video" },
>> 	 { "vdt", OPT_INT | HAS_ARG | OPT_EXPERT | OPT_VIDEO, {(void*)&video_discard}, "discard threshold", "n" },
>> Index: doc/ffmpeg-doc.texi
>> ===================================================================
>> --- doc/ffmpeg-doc.texi (revision 24008)
>> +++ doc/ffmpeg-doc.texi (working copy)
>> @@ -226,23 +226,23 @@
>>
>>  @item -aspect @var{aspect}
>>  Set aspect ratio (4:3, 16:9 or 1.3333, 1.7777).
>> - at item -croptop @var{size}
>> + at item -croptop @var{size} (deprecated - please use -vf crop=width:height:x:y)
>>  Set top crop band size (in pixels).
>> - at item -cropbottom @var{size}
>> + at item -cropbottom @var{size} (deprecated - please use -vf crop=width:height:x:y)
>>  Set bottom crop band size (in pixels).
>> - at item -cropleft @var{size}
>> + at item -cropleft @var{size} (deprecated - please use -vf crop=width:height:x:y)
>>  Set left crop band size (in pixels).
>> - at item -cropright @var{size}
>> + at item -cropright @var{size} (deprecated - please use -vf crop=width:height:x:y)
>>  Set right crop band size (in pixels).
>> - at item -padtop @var{size}
>> + at item -padtop @var{size} (non-functional - please use -vf pad=width:height:x:y:color)
>>  Set top pad band size (in pixels).
>> - at item -padbottom @var{size}
>> + at item -padbottom @var{size} (non-functional - please use -vf pad=width:height:x:y:color)
>>  Set bottom pad band size (in pixels).
>> - at item -padleft @var{size}
>> + at item -padleft @var{size} (non-functional - please use -vf pad=width:height:x:y:color)
>>  Set left pad band size (in pixels).
>> - at item -padright @var{size}
>> + at item -padright @var{size} (non-functional - please use -vf pad=width:height:x:y:color)
>>  Set right pad band size (in pixels).
>> - at item -padcolor @var{hex_color}
>> + at item -padcolor @var{hex_color} (non-functional - please use -vf pad=width:height:x:y:color)
>>  Set color of padded bands. The value for padcolor is expressed
>>  as a six digit hexadecimal number where the first two digits
>>  represent red, the middle two digits green and last two digits
>>     
> Applied the crop part.
>
> As for the pad, check attached. Another possibility would be to retain
> the -pad option entry, and state that they've been removed, but I
> prefer somehow this variant.
>   

Stefano, your version looks great to me. Thanks for taking the time to
get it right.

John