[FFmpeg-devel] [PATCH] move put_v from nutenc.c and make it public in avio.h and aviobuf.c

[Michael Niedermayer]

On Thu, Jul 01, 2010 at 11:08:48PM +0200, Michael Chinen wrote:
> On Thu, Jul 1, 2010 at 4:12 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> ?avio.h ? ?| ? ?6 ++++++
> >> ?aviobuf.c | ? 18 ++++++++++++++++++
> >> ?nutenc.c ?| ? 21 ---------------------
> >> ?3 files changed, 24 insertions(+), 21 deletions(-)
> >> aecf1d9c9221aae98ccd955b79236b9abb86f659 ?moving_put_v_r23915_2.patch
> >
> > ok but
> >
> > * they need ff_ prefixes (seperate patch/commit)
> > * get_v() needs doxy comment
> > * get_length() is too generic namewise (any renaming would go into a
> > ?seperate patch/commit)
> Okay, here are are the updated two patches that do this.
> I'm new to git so let me know if the patches are weird with email formating.

>  avio.h    |   10 ++++++++++
>  aviobuf.c |   18 ++++++++++++++++++
>  nutenc.c  |   21 ---------------------
>  3 files changed, 28 insertions(+), 21 deletions(-)
> 5b35a130a6f23863ad37ea8df74fb31cc78f3f94  0001-Move-put_v-and-get_length-which-put_v-uses-to-aviobu.patch
> From 808c169265b00926e09ecdb96e765ac81bba2693 Mon Sep 17 00:00:00 2001
> From: Michael Chinen <mchinen at gmail.com>
> Date: Thu, 1 Jul 2010 22:03:10 +0200
> Subject: [PATCH 1/2] Move put_v and get_length (which put_v uses) to aviobuf.c and avio.h as public functions.
>  put_v used to be static in nutenc.c, but it is a general purpose tool that can be useful for saving the index table to a file.
>  get_length is also made public because it is used within nutenc.c as well.
>  Unlike my previous patch commits, I hope this one can be reviewed and commited soon since it is independent of seeking api changes.
> To: mchinen at gmail.com

ok


>  avio.h    |    4 -
>  aviobuf.c |    6 +-
>  nutenc.c  |  130 +++++++++++++++++++++++++++++++-------------------------------
>  3 files changed, 70 insertions(+), 70 deletions(-)
> 566e7cbf641ce382cf7a81522a6f2ad5e0719098  0002-change-put_v-to-ff_put_v-and-get_length-to-ff_get_v_.patch
> From a1ccd01ad973fb863009bbe912e8631dec0f58cf Mon Sep 17 00:00:00 2001
> From: Michael Chinen <mchinen at gmail.com>
> Date: Thu, 1 Jul 2010 22:43:03 +0200
> Subject: [PATCH 2/2] change put_v to ff_put_v and get_length to ff_get_v_length.
>  they are being renamed because they are now public functions.
>  also updating nutenc.c to use the new names.
> To: mchinen at gmail.com

ok

also note, for future patches, it would be beter to add ff_ prefixes in the
first patch and do the moving  in the second.
That way the intermediate version does not risk symbol colissions

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100705/34481ead/attachment.pgp>