[FFmpeg-devel] [PATCH] Fix warnings in decode_significance_x86 and decode_significance_8x8_x86 (in h264_i386.h)

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Mon, Jul 05, 2010 at 08:02:09PM -0700, Eli Friedman wrote:
>> On Sat, Jul 3, 2010 at 10:07 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> > On Thu, Jul 1, 2010 at 9:46 AM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> >> On Sun, Jun 27, 2010 at 4:17 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> >>> On Sun, Jun 27, 2010 at 3:53 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >>>> On Sun, Jun 27, 2010 at 01:33:01PM -0700, Eli Friedman wrote:
>> >>>>> 2010/6/27 M?ns Rullg?rd <mans at mansr.com>:
>> >>>>> > Eli Friedman <eli.friedman at gmail.com> writes:
>> >>>>> >
>> >>>>> >> Patch attached; adds extra casts so gcc doesn't warn about truncating
>> >>>>> >> pointers.
>> >>>>> >
>> >>>>> > Do you mean "implicit conversion of pointer to integer of different size"?
>> >>>>>
>> >>>>> Yes.
>> >>>> [...]
>> >>>>> Okay, second try attached.
>> >>>>
>> >>>> if this generates identical object files: then i abstain from commenting
>> >>>> if it changes object files to being slower then i object to this change
>> >>>
>> >>> This generates identical object files, at least on gcc 4.4.
>> >>>
>> >>
>> >> Ping.
>> >
>> > PINGPINGPINGPINGPING.
>> >
>> 
>> This is completely ridiculous: this tiny patch hasn't had any response
>> in over a week!
>
> can someone please take care of tiny patch, play with it, feed it, make
> sure its not just sitting lonely and sad in the corner
> you guys are so cruel

I'm fine with the patch, but I'm not maintainer of that file, you are.

-- 
M?ns Rullg?rd
mans at mansr.com