[FFmpeg-devel] [PATCH] Add #ifdefs around code specific to file and pipe protocols

[Michael Niedermayer]

On Tue, Jul 06, 2010 at 02:17:33PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Tue, Jul 06, 2010 at 02:02:33PM +0100, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> 
> >> > On Tue, Jul 06, 2010 at 12:59:57AM +0100, Mans Rullgard wrote:
> >> >> ---
> >> >>  libavformat/file.c |   42 ++++++++++++++++++++++++------------------
> >> >>  1 files changed, 24 insertions(+), 18 deletions(-)
> >> >
> >> > more ifdefery is not good
> >> > so why?
> >> 
> >> So the protocols can be individually disabled should someone so
> >> desire.  Where is the harm in that?  Then again, it doesn't do much
> >> harm as is, so I'll drop the change.
> >
> > no, patch ok in that case
> 
> To clarify, both protocols are currently built (but not registered) if
> either of them is enabled.  They are in the same file because they
> share the read/write functions.

1 ifdef/endif is ok per protocol,and i think thats what the patch added
what iam alergic against is if additional ifdefs are added for unused
static functions and static tables, that the compiler could remove.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100706/a00e7ad1/attachment.pgp>