[FFmpeg-devel] [PATCH] Fix warnings in bidir_refine (in libavcodec/motion_est.c)

[Michael Niedermayer]

On Tue, Jul 06, 2010 at 12:10:34PM -0700, Eli Friedman wrote:
> 2010/7/6 M?ns Rullg?rd <mans at mansr.com>:
> > Eli Friedman <eli.friedman at gmail.com> writes:
> >
> >> 2010/7/3 M?ns Rullg?rd <mans at mansr.com>:
> >>> The warnings this thread is about are of the rare variety which cannot
> >>> be so easily silenced without adding clutter or having the actual code
> >>> change.
> >>
> >> Is the attached sufficiently unobtrusive to be acceptable?
> >>
> >> -Eli
> >>
> >> Index: motion_est.c
> >> ===================================================================
> >> --- motion_est.c ? ? ?(revision 24018)
> >> +++ motion_est.c ? ? ?(working copy)
> >> @@ -1509,22 +1509,23 @@
> >> ?{ 1, 1, 1,-1}, {-1,-1,-1, 1}, { 1, 1,-1, 1}, {-1,-1, 1,-1}, { 1,-1, 1, 1}, {-1, 1,-1,-1}, {-1, 1, 1, 1}, { 1,-1,-1,-1},
> >> ?{ 1, 1,-1,-1}, {-1,-1, 1, 1}, { 1,-1,-1, 1}, {-1, 1, 1,-1}, { 1,-1, 1,-1}, {-1, 1,-1, 1},
> >> ? ? ? ? ?};
> >> +#define HASH_T(fx,fy,bx,by) ((uint8_t)HASH(fx,fy,bx,by))
> >
> > What meaning is _T intended to convey? ?See also
> > http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/112370
> 
> It was supposed to stand for "truncated", but that isn't really
> clear... changed to HASH8, like you suggested in the referenced
> thread.

ok

also maybe you want to name your patches .diff or .patch

my diffstat & checksum insertion code doesnt work currently with patches
that are .txt and have non patchish mime type


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100707/4c59cd46/attachment.pgp>