[FFmpeg-devel] [misc-filters PATCH 4/8] Factorize out some code and implement the fill_line_with_color() function. Allow to share code with the pending color source.

[Michael Niedermayer]

On Wed, Jul 07, 2010 at 12:15:33AM +0200, Stefano Sabatini wrote:
> On date Tuesday 2010-07-06 12:01:02 +0100, M?ns Rullg?rd encoded:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Thu, Jul 01, 2010 at 10:50:08PM +0200, Stefano Sabatini wrote:
> > >> ---
> > >>  libavfilter/vf_pad.c |  106 ++++++++++++++++++++++++++-----------------------
> > >>  1 files changed, 56 insertions(+), 50 deletions(-)
> > >
> > > if you checked that this just moves code around then ok
> > 
> > It also replaces RGB_TO_[YUV]_CCIR with plain RGB_TO_[YUV].  I assume
> > this is a mistake.
> 
> I know how I messed it up, I copied code from the color source, which
> was pretty old code which was written when the pad filter was not
> still using _CCIR, I didn't noticed it when reading the patch (which I
> did not less than five times), and the lavfitest was passing anyway.

I would suggest that to compare 2 pieces of code that should be identical
that you open 2 windows and align the pieces, that way spotting differenes
becomes much easier


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100707/e65bca6a/attachment.pgp>