[FFmpeg-devel] [PATCH] Add a MAXDIST parameter to tiny_psnr (for 1-off fate tests)

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Thu, Jul 08, 2010 at 10:07:09PM +0200, Vitor Sessak wrote:
>> On 07/08/2010 09:53 PM, Jason Garrett-Glaser wrote:
>>> On Thu, Jul 8, 2010 at 11:56 AM, Vitor Sessak<vitor1001 at gmail.com>  wrote:
>>>> On 07/08/2010 08:51 PM, Ronald S. Bultje wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> On Thu, Jul 8, 2010 at 2:47 PM, Vitor Sessak<vitor1001 at gmail.com>    
>>>>> wrote:
>>>>>>
>>>>>> $subj, it is necessary to get FATE to test float-based codecs (at least
>>>>>> locally through "make fate") by checking if MAXDIST == 1. Comments are
>>>>>> welcome.
>>>>>
>>>>> [..]
>>>>>>
>>>>>> +            dist = a-b;
>>>>>> +            dist = dist<    0 ? -dist : dist;
>>>>>
>>>>> FFABS().
>>>>
>>>> That would add a new dependency on lavu to it, what is not the case until
>>>> now.
>>>
>>> What about, just... abs()?
>>
>> Indeed, it is already used elsewhere (thus present in all supported archs). 
>> New patch attached.
>>
>> -Vitor
>
>>  tiny_psnr.c |    7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>> 7ee3107d71082abc3cd3f5c82d247c150ac9ac4f  one-off_2.diff
>
> fine with me

Already applied since it seemed harmless, but thanks for looking.

-- 
M?ns Rullg?rd
mans at mansr.com