[FFmpeg-devel] [PATCH] MMX2/SSSE3 VC1 loop filter

[David Conrad]

On Jul 5, 2010, at 12:55 AM, Kostya wrote:

> On Mon, Jul 05, 2010 at 12:11:30AM -0400, David Conrad wrote:
>> On Jul 4, 2010, at 2:30 PM, Carl Eugen Hoyos wrote:
>> 
>>> Kostya <kostya.shishkov <at> gmail.com> writes:
>>> 
>>>>> It seems this got lost?
>>>> 
>>>> probably it just slipped past me - I was visiting my homeland then
>>>> 
>>>> If it still works then ok.
>>> 
>>> I'd like to add two comments:
>>> 
>>> Is there any indication that the C-version of the loop-filter is bit-exact? Am I
>>> correct that if not, this patch would not improve things?
>> 
>> IIRC the loop filter C code is correct, but the rules for applying it are rather convoluted and not implemented quite right for P frames.
> 
> Could be. BTW, P-frame loop filter order also differs in old not (yet)
> supported WMV3.
> 
>> Looks like I lost the fixes for I/B frames too, attached...
>> 
>>> And since I consider this a more important codec than VP8: Could this be truly
>>> reviewed to see possible additional optimisations? I assume loop filtering takes
>>> a lot of time...
>> 
> 
> Commit ff_draw_horiz_band() first separately, otherwise it's OK for me.

Done and applied.

The fate test spec will have to be updated. It's still not exact to the reference, but the errors are a little less now.