[FFmpeg-devel] [RFC] libavfilter audio - af_resample

[S.N. Hemanth Meenakshisundaram]

Michael Niedermayer wrote:
> On Tue, Jul 13, 2010 at 03:14:31AM -0700, S.N. Hemanth Meenakshisundaram wrote:
>   
>> Michael Niedermayer wrote:
>>     
>>> On Sat, Jul 10, 2010 at 11:37:54PM +0100, M?ns Rullg?rd wrote:
>>>   
>>>       
>>>> Michael Niedermayer <michaelni at gmx.at> writes:
>>>>
>>>>     
>>>>         
>> Of course, vf_scale internally calls libswscale while af_resample is 
>> currently duplicating a lot of lavc's resample & audioconvert.c code 
>> internally so I could make changes if necessary.
>>
>> Should I instead wrap audioconvert for sample format conversion (use 
>> av_audio_convert) and wrap resample.c for channel mixing. Also, perhaps 
>> af_resample should be renamed to reformat to avoid confusing with the 
>> downsampling/upsampling in lavc resample2.c
>>     
>
> code should be efficient, not doing unneeded operations or copying.
> It would also be a plus if the individual parts could be used without
> avfilter.
>
>
> [...]
>   
Hi All,

Attached is a patch for af_resample.c to avoid double free and so it 
works with the common Pix Formats/Sample Formats enum. This only shows 
differences from the previous version sent.

If no conversions are required, it just passes on the buffer to the next 
filter.

I'll update libavfilter.texi with usage info. Since individual parts 
need to be used externally, I will rewrite this to wrap available lavc 
code wherever possible.

Regards,
Hemanth

-------------- next part --------------
A non-text attachment was scrubbed...
Name: resample_new.diff
Type: text/x-patch
Size: 4291 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100714/75c4e23d/attachment.bin>