[FFmpeg-devel] [PATCH] Lego Mindstorms RSO de/muxer (copied from au.c)

[Rafaël Carré]

On Wed, 14 Jul 2010 23:44:02 +0200
Diego Biurrun <diego at biurrun.de> wrote:

Hi,

> On Wed, Jul 14, 2010 at 09:54:31PM +0200, Rafa?l Carr? wrote:
> > - format from http://bricxcc.sourceforge.net/
> 
> This is missing a minor version bump and a documentation update.

I'll add the minor version bump in next patch

Where should the documentation go?

> > --- /dev/null
> > +++ b/libavformat/rso.c
> > @@ -0,0 +1,203 @@
> > +/*
> > + * RSO muxer and demuxer
> > + * Copyright (c) 2001 Fabrice Bellard (original AU code)
> > + * Copyright ?? 2010 Rafa??l Carr??
> 
> Please use UTF-8

I'm pretty sure it is UTF-8 already

> > +#if CONFIG_RSO_MUXER
> 
> Split muxer and demuxer into separate files and avoid the #ifdefs.

Ok, I'll do that and move codec_rso_tags + RSO_HEADER_SIZE into a .h

> > +static int rso_read_packet(AVFormatContext *s,
> > +                          AVPacket *pkt)
> 
> Indentation is off; just don't break this short line.

Oops missed that one, I'll correct it

Thanks,

-- 
? Rafa?l Carr? ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100714/628e37f7/attachment.pgp>