[FFmpeg-devel] [PATCH] adding xavs encoding support

[jianwen chen]

2010/7/16 M?ns Rullg?rd <mans at mansr.com>

> jianwen chen <jianwen.chen.video at gmail.com> writes:
>
> > Dears,
> >
> > Attached is the latest patch to support xavs encoding in ffmpeg.
> >
> > And please put the libxavs.c to  ffmpeg source code under
> ffmpeg/libavcodec/
> >
> > Index: configure
> > ===================================================================
> > --- configure (revision 24248)
> > +++ configure (working copy)
> > @@ -2660,6 +2664,9 @@
> >  enabled libx264    && require  libx264 x264.h x264_encoder_encode -lx264
> &&
> >                        { check_cpp_condition x264.h "X264_BUILD >= 98" ||
> >                          die "ERROR: libx264 version must be >= 0.98."; }
> > +enabled libxavs    && require  libxavs xavs.h xavs_encoder_encode -lxavs
> -lm &&
> > +                   { check_cpp_condition xavs.h "XAVS_BUILD >= 1" ||
> > +                        die "ERROR: libxavs version should at least be
> 1"; }
>
> Until some specific version is required, the additional check is
> unnecessary.
>

   Yes, I agree with you.  I delete this check from the  configure  file.


> > Index: libavcodec/avcodec.h
> > ===================================================================
> > --- libavcodec/avcodec.h      (revision 24248)
> > +++ libavcodec/avcodec.h      (working copy)
> > @@ -2382,6 +2382,12 @@
> >  #define X264_PART_P4X4 0x020  /* Analyze p8x4, p4x8, p4x4 */
> >  #define X264_PART_B8X8 0x100  /* Analyze b16x8, b8x16 and b8x8 */
> >
> > +#define XAVS_PART_I4X4 0x001  /* Analyze i4x4 */
> > +#define XAVS_PART_P4X4 0x020  /* Analyze p8x4, p4x8, p4x4 */
> > +#define XAVS_PART_I8X8 0x002  /* Analyze i8x8 (requires 8x8 transform)
> */
> > +#define XAVS_PART_P8X8 0x010  /* Analyze p16x8, p8x16 and p8x8 */
> > +#define XAVS_PART_B8X8 0x100  /* Analyze b16x8, b8x16 and b8x8 */
>
> I see no reason for adding additional defines for the same values with
> the same meanings as the x264 ones.
>

For cavs encoding, there is only 8x8 partition by now. We will use other
definition in the future.
So we can delete it in  avcodec.h in this stage.
Based on your comments, the new patch is attached. Please check. Thanks.


Regards,
Jianwen

>
> --
> M?ns Rullg?rd
> mans at mansr.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-ffmpeg-svn-r24248-for-libxavs-update.patch
Type: application/octet-stream
Size: 19075 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100716/57e41b86/attachment.obj>