[FFmpeg-devel] [WIP] overlay filter

[Víctor Paesa]

Hi,

On Fri, Jul 16, 2010 at 19:02, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> Hi all,
> this is a work in progress based on Bobby and Baptiste work.
>
> It's not yet ready for review, I'm sending it here in case someone
> wants to have a look at it and/or commenting it.

> +static const char *var_names[] = {
> +    "E",
> +    "PI",
> +    "main_w",    ///< width  of the main    video
> +    "main_h",    ///< height of the main    video
> +    "overlay_w", ///< width  of the overlay video
> +    "overlay_h", ///< height of the overlay video
> +    NULL
> +};

I would use a more brief notation: uppercase W/H for main video
and lowercase w/h for the video overlaid.
Also, given these variables will be used within math expressions,
the underscore might be mistaken for a minus (on a quick glance).

I miss too some time related variable (frame number or pts), but
of course, this may be added later.

Regards,
V?ctor