[FFmpeg-devel] [PATCH] adding xavs encoding support

[jianwen chen]

OK.  I have modified the code according to the comments.

Please check the attached patch .

Thanks
Jianwen


On Sat, Jul 17, 2010 at 9:59 AM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Fri, Jul 16, 2010 at 09:52:03AM +0800, jianwen chen wrote:
> [...]
> > + * You should have received a copy of the GNU Lesser General Public
> > + * License along with FFmpeg; if not, write to the Free Software
> > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301 USA
> > + */
> > +
> > +#include "avcodec.h"
> > +#include "libavutil/log.h"
>
> > +//#include "libavutil/avutil.h"
>
> useless
>
>
> [...]
> > +static void XAVS_log(void *p, int level, const char *fmt, va_list args)
> > +{
> > +    static const int level_map[] = {
> > +        [XAVS_LOG_ERROR]   = AV_LOG_ERROR,
> > +        [XAVS_LOG_WARNING] = AV_LOG_WARNING,
> > +        [XAVS_LOG_INFO]    = AV_LOG_INFO,
> > +        [XAVS_LOG_DEBUG]   = AV_LOG_DEBUG
> > +    };
> > +
> > +    if (level < 0 || level > XAVS_LOG_DEBUG)
> > +        return;
> > +
> > +    av_vlog(p, level_map[level], fmt, args);
> > +}
> > +
> > +#if XAVS_BUILD >= 2
>
> i dont think theres a point in supporting old versions
>
>
> [...]
> > +#if XAVS_BUILD >= 1 /*AMANDA TAG: Amanda thinks this is only used for
> counting the fps*/
> > +    x4->params.i_fps_num  = avctx->time_base.den;
> > +    x4->params.i_fps_den  = avctx->time_base.num;
> > +#endif
> > +#if 1//XAVS_BUILD>1
> > +    x4->params.analyse.inter    = XAVS_ANALYSE_I8x8
> |XAVS_ANALYSE_PSUB16x16| XAVS_ANALYSE_BSUB16x16;
> > +#else
> > +    x4->params.analyse.inter    = 0;
> > +#endif
> > +    if (avctx->partitions) {
>
> > +             /*AMANDA TAG: No 4x4 in AVS P1.0*/
>
> tabs, you should try our patcheck script
>
>
> > +#if 0
> > +       if (avctx->partitions & XAVS_PART_I4X4)
> > +            x4->params.analyse.inter |= XAVS_ANALYSE_I4x4;
> > +       if (avctx->partitions & XAVS_PART_P4X4)
> > +            x4->params.analyse.inter |= XAVS_ANALYSE_PSUB8x8;
> > +#endif
>
> > +        if (avctx->partitions & XAVS_PART_I8X8)
>
> thats not the correct mask to test this field against
>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If a bugfix only changes things apparently unrelated to the bug with no
> further explanation, that is a good sign that the bugfix is wrong.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iD8DBQFMQQ6DYR7HhwQLD6sRAhJFAJwIJk6k63qLGT3XCSFhxKpoOR1hpgCghPm4
> b5/4olFauVaOEf4dqYuG1MQ=
> =EDBo
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-ffmpeg-svn-r24248-for-libxavs-update2.patch
Type: application/octet-stream
Size: 16326 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100717/9d035394/attachment.obj>