[FFmpeg-devel] [RFC] libavfilter audio framework - split patches

[Michael Niedermayer]

On Sat, Jul 17, 2010 at 04:41:36PM -0700, S.N. Hemanth Meenakshisundaram wrote:
> On 07/17/2010 12:28 PM, Michael Niedermayer wrote:
> > On Sat, Jul 17, 2010 at 09:22:55PM +0200, Stefano Sabatini wrote:
> >   
> >> On date Friday 2010-07-16 01:01:39 -0700, S.N. Hemanth Meenakshisundaram encoded:
> >>     
> >>> On 07/16/2010 01:00 AM, S.N. Hemanth Meenakshisundaram wrote:
> >>>       
> >>>
> >>> diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
> >>> index c8db36f..50b558e 100644
> >>> --- a/libavfilter/avfilter.h
> >>> +++ b/libavfilter/avfilter.h
> >>> @@ -71,7 +71,7 @@ typedef struct AVFilterBuffer
> >>>  {
> >>>      uint8_t *data[4];           ///< picture data for each plane
> >>>      int linesize[4];            ///< number of bytes per line
> >>> -    enum PixelFormat format;    ///< colorspace
> >>> +    int format;                 ///< colorspace
> >>>       
> >> Update docs, that may say: colorspace or sample format
> >>
> >> Also I'm not very happy about the use of an int. What about something
> >> like this:
> >>
> >> struct AVFilterBuffer
> >> {
> >>    enum AVMediaType type;
> >>    ...
> >>
> >>    union {
> >>        enum PixelFormat  video_format;
> >>        enum SampleFormat audio_format;
> >>     
> >                                 ^^^^^^^
> > unneeded?

_format is unneeded in the name

format.video_format looks odd

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100718/464b934d/attachment.pgp>