[FFmpeg-devel] [PATCH] Move link_dpad and link_spad macros from avfilter.c to internal.h, so

[Michael Niedermayer]

On Mon, Jul 19, 2010 at 06:19:56PM +0200, Stefano Sabatini wrote:
> ---
>  libavfilter/avfilter.c |    4 ----
>  libavfilter/internal.h |    4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
> index dc8f90d..e81fa48 100644
> --- a/libavfilter/avfilter.c
> +++ b/libavfilter/avfilter.c
> @@ -41,10 +41,6 @@ const char *avfilter_license(void)
>      return LICENSE_PREFIX FFMPEG_LICENSE + sizeof(LICENSE_PREFIX) - 1;
>  }
>  
> -/** helper macros to get the in/out pad on the dst/src filter */
> -#define link_dpad(link)     link->dst-> input_pads[link->dstpad]
> -#define link_spad(link)     link->src->output_pads[link->srcpad]
> -

iam against such obfuscation macros

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100720/65958a36/attachment.pgp>