[FFmpeg-devel] [RFC] swscale regression tests

[Måns Rullgård]

Ramiro Polla <ramiro.polla at gmail.com> writes:

> 2010/7/20 M?ns Rullg?rd <mans at mansr.com>:
>> Ramiro Polla <ramiro.polla at gmail.com> writes:
>>> I have attached an attempt at making swscale regression tests. This
>>> method creates one file for each input pixel format (currently 42) and
>>> compresses the output with bzip2. I have not tested with different
>>> platforms (x86_64 linux only yet), and IIRC it doesn't give the same
>>> result on all platforms. This is just a request for comments whether
>>> this approach is good. I have also removed the fast bilinear test
>>> since it works differently on many platforms and would make the
>>> regression tests more complex (like keeping one reference file for
>>> each platform).
>>>
>>> The output bzip2ed files add 280Kb of binary data to repository (5.6Mb
>>> uncompressed). As for disk usage (with 'du'), it takes 340Kb (5.8Mb
>>> uncompressed).
>>
>> Why can't you store a checksum instead?
>
> Storing a checksum makes it harder to find out which test failed. And
> the compressed files don't seem to take as much space as I had
> originally thought they would take.

Then why are you bundling many tests together?

>>> --- /dev/null 2009-04-20 11:01:36.000000000 -0300
>>> +++ tests/swscale-regression.sh ? ? ? 2010-07-20 00:38:29.000000000 -0300
>>> @@ -0,0 +1,12 @@
>>> +#!/bin/sh
>>> +#
>>> +# automatic regression test for libswscale
>>> +#
>>> +#
>>> +#set -x
>>
>> Do we really need to cargo-cult that around _all_ the scripts?
>
> If we don't put it, someone will yell that it's not consistent, and if
> we want it removed, that takes another patch and potentially more
> discussion. Anyways, patch attached to remove those comments (the file
> name should be descriptive enough already).
>
> Also why is there a space after the shebang in some scripts? (like "#!
> /bin/sh"). It's not wrong, but just weird, and wastes one byte =)

Some systems insist on the space.  It's a good habit to always include
it.

-- 
M?ns Rullg?rd
mans at mansr.com