[FFmpeg-devel] [PATCH] Rename dprintf macro to ff_dprintf.

[Måns Rullgård]

Benoit Fouet <benoit.fouet at free.fr> writes:

> Hi,
>
> On Wed, 21 Jul 2010 16:32:40 +0200 Diego Elio 'Flameeyes' Petten? wrote:
>
> [...]
>
>> diff --git a/libavutil/internal.h b/libavutil/internal.h
>> index 53d2b94..d736e2f 100644
>> --- a/libavutil/internal.h
>> +++ b/libavutil/internal.h
>> @@ -114,11 +114,11 @@
>>  
>>  /* debug stuff */
>>  
>> -/* dprintf macros */
>> +/* ff_dprintf macros */
>>  #ifdef DEBUG
>> -#    define dprintf(pctx, ...) av_log(pctx, AV_LOG_DEBUG, __VA_ARGS__)
>> +#    define ff_dprintf(pctx, ...) av_log(pctx, AV_LOG_DEBUG, __VA_ARGS__)
>>  #else
>> -#    define dprintf(pctx, ...)
>> +#    define ff_dprintf(pctx, ...)
>>  #endif
>>  
>
> I think you should you also add the following lines in this file:
>
> #undef  dprintf
> #define dprintf please_use_av_log_instead_of_dprintf

Why?  dprintf() is fprintf() for raw file descriptors.  Even if using
it should be avoided for some reason, av_log() is not a replacement.

-- 
M?ns Rullg?rd
mans at mansr.com