[FFmpeg-devel] [PATCH] Use more appropriate types when decoding vorbisfloats

[Michael Niedermayer]

On Sat, Jul 24, 2010 at 04:15:18AM +0200, Rafa?l Carr? wrote:
> On Fri, 23 Jul 2010 18:10:45 -0400
> Alex Converse <alex.converse at gmail.com> wrote:
> 
> Hi,
> 
> > Index: libavcodec/vorbis_dec.c
> > ===================================================================
> > --- libavcodec/vorbis_dec.c	(revision 24471)
> > +++ libavcodec/vorbis_dec.c	(working copy)
> > @@ -178,11 +178,11 @@
> >  
> >  static float vorbisfloat2float(uint_fast32_t val)
> >  {
> > -    double mant = val & 0x1fffff;
> > -    long exp    = (val & 0x7fe00000L) >> 21;
> > +    float mant = val & 0x1fffff;
> > +    int exp    = (val & 0x7fe00000L) >> 21;
>                                      ^
> Shouldn't the L be dropped too?

patcheck is sad that it cant detect that, want to make it happy with a
patch?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100724/bc6cbf3a/attachment.pgp>