[FFmpeg-devel] [PATCH] libavcodec/wmavoice.c: local variable pow might mask pow function

[Ronald S. Bultje]

Hi,

On Mon, Jul 26, 2010 at 9:47 AM, Benjamin Larsson <banan at ludd.ltu.se> wrote:
> Michael Niedermayer skrev 2010-07-26 14:07:
>> On Sun, Jul 25, 2010 at 07:34:25PM +0200, Axel Holzinger wrote:
>>> in libavcodec/wmavoice.c local variable float pow (line 585) can mask
>>> pow function if powf (line 595) is a #define and defined for example
>>> like
>>> #define powf(x,y) ? ((float)pow((double)(x), (double)(y)))
>>>
>>> The attached patch reduces ambiguity by renaming the local variable
>>> with pwr:
>>>
>>
>> iam in favor of this workaround for buggy ms headers and code
>> clarification
>
> I'm also in favor of this. FFmpeg isn't compiled with c99 compatible
> compilers all the time.

Good, applied && discussion closed. Let's get back to coding guys. :-).

Ronald