[FFmpeg-devel] [PATCH 3/5] Use int for num_faulty_pts/dts instead of int64_t

Michael Niedermayer michaelni
Tue Jul 27 15:04:45 CEST 2010


On Mon, Jul 26, 2010 at 01:16:08PM -0700, Alexander Strange wrote:
> ---
>  cmdutils.h |    4 ++--
>  ffplay.c   |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

this change is wrong and unneeded, int64_t is needed to ensure they dont
overflow. Consider audio with 1 sample per packet, it would overflow
within less than a day. the code must be able to run for years without
failing and it would fail for much more realistic audio packet sizes in
that period

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100727/e10d14ac/attachment.pgp>



More information about the ffmpeg-devel mailing list