[FFmpeg-devel] [PATCH 1/1] Move fill_image_linesize() and fill_image_data_ptr() from libavcodec and make them public in libavcore/imgutils.h.

[Stefano Sabatini]

On date Wednesday 2010-07-28 23:54:52 +0200, Michael Niedermayer encoded:
> On Wed, Jul 28, 2010 at 07:24:19PM +0200, Stefano Sabatini wrote:
> > On date Wednesday 2010-07-28 16:27:56 +0200, Michael Niedermayer encoded:
> > > On Wed, Jul 28, 2010 at 11:27:11AM +0200, Stefano Sabatini wrote:
> > > > ---
> > > >  libavcodec/imgconvert.c |  144 +----------------------------------------
> > > >  libavcore/Makefile      |    4 +-
> > > >  libavcore/imgutils.c    |  164 +++++++++++++++++++++++++++++++++++++++++++++++
> > > >  libavcore/imgutils.h    |   49 ++++++++++++++
> > > >  4 files changed, 219 insertions(+), 142 deletions(-)
> > > >  create mode 100644 libavcore/imgutils.c
> > > >  create mode 100644 libavcore/imgutils.h
> > > 
> > > 
> > > ok
> > 
> > Now it's a good time to bikeshed on the names, in my order of
> > preference:
> > 
> > av_fill_image_pointer:      simple, consistent with av_fill_image_linesize
> 
> semantically wrong due to singular
> 
> 
> > av_fill_image_pointers:     simple, av_fill_image_linesize should be changed to linesizes
> 
> 
> > av_fill_image_data:         simple, possibly confusing as it's not clear what "data" is
> 
> semantically wrong due to no "pointer"
> 
> 
> > av_fill_image_data_ptr:     redundant, sligthly ugly
> > av_fill_image_data_pointer: redundant, long
> 
> semantically wrong due to singular

So it only remains:
av_fill_image_pointers()
av_fill_image_linesizes()

Fine? I'll apply tomorrow if I see no objections.

Regards.
-- 
FFmpeg = Freak Formidable Mind-dumbing Puritan Extensive Gospel