[FFmpeg-devel] [PATCH] Export mkv doctype via the metadata API

[Aurelien Jacobs]

On Wed, Jul 28, 2010 at 12:31:05AM -0400, Alex Converse wrote:
> We do something similar for mp4/mov.
> 
> If people think this is stupid then I won't put up much of a fuss.
> 
> Regards,
> Alex

> Index: libavformat/matroskadec.c
> ===================================================================
> --- libavformat/matroskadec.c	(revision 24559)
> +++ libavformat/matroskadec.c	(working copy)
> @@ -1180,6 +1180,7 @@
>      if (i >= FF_ARRAY_ELEMS(matroska_doctypes)) {
>          av_log(s, AV_LOG_WARNING, "Unknown EBML doctype '%s'\n", ebml.doctype);
>      }
> +    av_metadata_set2(&s->metadata, "doctype", ebml.doctype, 0);
>      ebml_free(ebml_syntax, &ebml);

No way !
doctype is not a metadata.

If people really want to distinguish webm as a different format, the
best way may be to have a distinct webm demuxer. This better fit lavf
API, and it matches the webm muxer.
So if you tell me it's useful, I will apply attached patch.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: webm_demux.diff
Type: text/x-diff
Size: 3748 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100729/d23ab2dd/attachment.diff>