[FFmpeg-devel] [PATCH] Export mkv doctype via the metadata API

[Baptiste Coudurier]

On 07/28/2010 03:28 PM, Alex Converse wrote:
> On Wed, Jul 28, 2010 at 6:19 PM, Aurelien Jacobs<aurel at gnuage.org>  wrote:
>> On Wed, Jul 28, 2010 at 12:31:05AM -0400, Alex Converse wrote:
>>> We do something similar for mp4/mov.
>>>
>>> If people think this is stupid then I won't put up much of a fuss.
>>>
>>> Regards,
>>> Alex
>>
>>> Index: libavformat/matroskadec.c
>>> ===================================================================
>>> --- libavformat/matroskadec.c (revision 24559)
>>> +++ libavformat/matroskadec.c (working copy)
>>> @@ -1180,6 +1180,7 @@
>>>       if (i>= FF_ARRAY_ELEMS(matroska_doctypes)) {
>>>           av_log(s, AV_LOG_WARNING, "Unknown EBML doctype '%s'\n", ebml.doctype);
>>>       }
>>> +    av_metadata_set2(&s->metadata, "doctype", ebml.doctype, 0);
>>>       ebml_free(ebml_syntax,&ebml);
>>
>> No way !
>> doctype is not a metadata.
>>
>
> and major_brand is?

Both are.

>> If people really want to distinguish webm as a different format, the
>> best way may be to have a distinct webm demuxer. This better fit lavf
>> API, and it matches the webm muxer.
>> So if you tell me it's useful, I will apply attached patch.

I'm strongly opposed to that, cluttering the build system is useless.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org