[FFmpeg-devel] [RESEND][PATCH] libswscale: Extend?the?unaccelerated path of the unscaled yuv2rgb special converter?with?support for rgb444 output format

[Michael Niedermayer]

On Tue, Mar 02, 2010 at 02:50:05PM +0100, Janusz Krzysztofik wrote:
> Tuesday 02 March 2010 13:57:56 Michael Niedermayer napisa?(a):
> > On Tue, Mar 02, 2010 at 01:41:50PM +0100, Janusz Krzysztofik wrote:
> > > Tuesday 02 March 2010 12:56:14 Michael Niedermayer wrote:
> > > > On Mon, Mar 01, 2010 at 02:09:56AM +0100, Janusz Krzysztofik wrote:
> >
> > [...]
> >
> > > > also it seems dithering is missing
> > >
> > > To be sure: you didn't mean it's missing from the unscaled yuv2rgb
> > > special converter rgb444 output format support I'm trying to provide with
> > > this patch, did you?
> >
> > i think it would look better with dithering
> 
> Forgive me my ignorance: does it mean I shouldn't use existing yuv2rgb_c_16() 
> function for rgb444 but rather create a new one, like yuv2rgb_c_12_dither(), 
> possibly derieving it from yuv2rgb_c_8_ordered_dither(), with its specific 
> PUTRGB12() macro derieved form PUTRGB8()?

something like this, yes
you also will need a new table, that is divide all values of
dither_8x8_32 by 2


> Then, would it also be necessary to 
> correct my code for rgb444 c->yuvTable initialization in 
> ff_yuv2rgb_c_init_tables()?

i suspect not or not much (maybe making something a little bit bigger if
there are out of array accesses)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100302/6f5ea6e3/attachment.pgp>